[ioctl] add checking --insecure in newcmd #3781

huof6829 · 2023-01-19T15:15:16Z

Description

insecure init value is from config file already. so just add error message if run fail.

Type of change

Please delete options that are not relevant.

[] Bug fix (non-breaking change which fixes an issue)
[] New feature (non-breaking change which adds functionality)
[] Code refactor or improvement
[] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
[] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[] make test
[] fullsync
[] Other test (please specify)

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Checklist:

[] My code follows the style guidelines of this project
[] I have performed a self-review of my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have made corresponding changes to the documentation
[] My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
[] New and existing unit tests pass locally with my changes
[] Any dependent changes have been merged and published in downstream modules

huof6829 · 2023-01-19T15:17:06Z

codecov · 2023-01-19T15:31:10Z

Codecov Report

Merging #3781 (130b46b) into master (263ff82) will increase coverage by 0.91%.
The diff coverage is 80.52%.

❗ Current head 130b46b differs from pull request most recent head 36937bd. Consider uploading reports for the commit 36937bd to get more accurate results

@@            Coverage Diff             @@
##           master    #3781      +/-   ##
==========================================
+ Coverage   74.47%   75.38%   +0.91%     
==========================================
  Files         269      303      +34     
  Lines       23925    25835    +1910     
==========================================
+ Hits        17818    19476    +1658     
- Misses       5174     5341     +167     
- Partials      933     1018      +85

Impacted Files	Coverage Δ
action/actctx.go	`90.62% <ø> (+6.25%)`	⬆️
action/action.go	`82.35% <ø> (ø)`
action/action_deserializer.go	`57.14% <ø> (ø)`
action/candidate_update.go	`88.88% <0.00%> (-4.14%)`	⬇️
action/consignment_transfer.go	`90.41% <ø> (ø)`
action/const.go	`100.00% <ø> (ø)`
action/execution.go	`83.78% <ø> (ø)`
action/grantreward.go	`68.57% <ø> (ø)`
action/protocol/account/protocol.go	`86.90% <ø> (ø)`
action/protocol/dock.go	`100.00% <ø> (ø)`
... and 282 more